thakis added a comment. > So, some notes: > > - We should probably also do an AKA on the type diff. > - Chromium should use a clearer name for that typedef perhaps? Though calling > the first template parameter of span as `T` is common, maybe a better name > here would be `element_type`. > > Having a convenient way to just name a type like that also seems useful, so > maybe the rename coupled with the AKA would be an improvement overall?
Haha :) Thanks for taking a look. aka for typedefs sounds like a nice approach to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110216/new/ https://reviews.llvm.org/D110216 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
