george.burgess.iv accepted this revision.
george.burgess.iv added a comment.
This revision is now accepted and ready to land.
LGTM % 2 nits. Please feel free to commit after it LGT @aaron.ballman too. :)
Thanks again!
================
Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:2961
+ "%0 attribute references function %1, which %plural{0:takes no
arguments|1:takes one argument|"
+ ":requires exactly %2 arguments}2">;
+def err_attribute_bounds_for_function : Error<
----------------
tiny nit: for consistency with the other options here
================
Comment at: clang/test/Sema/attr-diagnose-as-builtin.c:62
+
+#ifdef __cplusplus
+template <class T>
----------------
nit: can we also add a non-templated overload check in here?
if the diag isn't beautiful, that's fine IMO. just having a test-case to show
the expected behavior would be nice
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D112024/new/
https://reviews.llvm.org/D112024
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
