rriddle added inline comments.
================ Comment at: llvm/include/llvm/ADT/Hashing.h:59 namespace llvm { -template <typename T> struct DenseMapInfo; ---------------- lattner wrote: > Is there a way to keep the forward declarations references here instead of > #include? DenseMapInfo.h pulls in a ton of stuff including <utility> and > <tuple> I mentioned it in a comment. If we don't want the includes, we'll need to sprinkle `void` everywhere that we specialize the template. (I don't have a preference either way) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113641/new/ https://reviews.llvm.org/D113641 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits