zoecarver accepted this revision.
zoecarver added inline comments.
This revision is now accepted and ready to land.
================
Comment at: clang/lib/CodeGen/CGObjCMac.cpp:6683
+ values.add(classMethodList);
+ isEmptyCategory &=
+ instanceMethodList->isNullValue() && classMethodList->isNullValue();
----------------
Does this really need to be an `&=`? Is there any case where `isEmptyCategory`
isn't `true` here?
================
Comment at: clang/test/CodeGenObjC/category-class-empty.m:1
+// RUN: %clang_cc1 -triple i386-apple-darwin9 -O3 -emit-llvm -o - %s |
FileCheck %s
+// PR7431
----------------
Is `-O3` needed here?
================
Comment at: clang/test/CodeGenObjC/non-lazy-classes.m:45
__attribute__((objc_nonlazy_class))
-@implementation E (MyCat) @end
+@implementation E (MyCat)
+-(void) load {
----------------
This is to prevent another test from failing? Makes sense.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D113455/new/
https://reviews.llvm.org/D113455
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
