kcc marked an inline comment as done. kcc added inline comments.
================ Comment at: clang/test/Driver/autocomplete.c:73 // FNOSANICOVERALL-NEXT: trace-pc-guard +// FNOSANICOVERALL-NEXT: trace-loads +// FNOSANICOVERALL-NEXT: trace-stores ---------------- morehouse wrote: > This check is failing in the harbormaster build: > https://reviews.llvm.org/harbormaster/unit/view/1482705/ removed ================ Comment at: compiler-rt/test/sanitizer_common/TestCases/sanitizer_coverage_trace_loads_stores.cpp:5 +// +// RUN: %clangxx -O0 %s -fsanitize-coverage=func,trace-loads,trace-stores -o %t +// RUN: %run %t 2>&1 | FileCheck %s ---------------- morehouse wrote: > According to the documentation update in this patch, these flags don't work > without trace-pc or inline-8bit-counters. Right. "func" is sort of synonym for trace-pc,func, but it's not worth the confusion in the test. changed to trace-pc Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113447/new/ https://reviews.llvm.org/D113447 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
