sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.
================
Comment at: clang/test/SemaCXX/base-class-ambiguity-check.cpp:15
+
+ // Should not crash on an incomplete-type base specifier.
+ struct Derived : Base {};
----------------
maybe put (dependent) in this comment, as it's the reason this code is valid
without diagnostics
================
Comment at: clang/test/SemaCXX/base-class-ambiguity-check.cpp:17
+ struct Derived : Base {};
+};
----------------
we're asserting here there are no diagnostics, maybe instantiate the template
and assert those?
================
Comment at: clang/test/SemaCXX/ms-interface.cpp:114
+ // Should not crash on an incomplete-type base specifier.
+ __interface Foo : Base {};
+};
----------------
is there some tricky interaction with __interface here that justifies testing
this again? If it's testing the same codepath, I'd say one test is enough
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D113474/new/
https://reviews.llvm.org/D113474
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
