salman-javed-nz added a comment. clang-tidy looking for `NOLINT` markers but not checking to see that the marker is within a comment, is long-standing behaviour at this point. cpplint has the same behaviour, which explains why clang-tidy's implementation started off this way.
That's not to say that we have to keep this way forever. I would love for it to be improved. However, discussing what the new behaviour should be and delivering it is beyond the scope of this patch, which is just trying to fix lint warnings in the current day framework. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113472/new/ https://reviews.llvm.org/D113472 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
