dmgreen added inline comments.
================
Comment at: llvm/include/llvm/Support/AArch64TargetParser.def:159-160
AArch64::AEK_RCPC | AArch64::AEK_SSBS))
+AARCH64_CPU_NAME("cortex-a710", ARMV9A, FK_NEON_FP_ARMV8, false,
+ (AArch64::AEK_MTE | AArch64::AEK_PAUTH | AArch64::AEK_FLAGM |
+ AArch64::AEK_SB | AArch64::AEK_I8MM | AArch64::AEK_FP16FML |
----------------
Natural order would be better I think, where the new A710 is added after the
A78.
FlagM should already be included as a part of 8.4, so isn't needed here.
Should BFloat16 be added?
================
Comment at: llvm/lib/Target/AArch64/AArch64.td:648
+def TuneA710 : SubtargetFeature<"a710", "ARMProcFamily", "CortexA710",
+ "Cortex-A710 ARM processors", [
----------------
Order below, and you can add FeatureCmpBccFusion according to the optimization
guide.
================
Comment at: llvm/lib/Target/AArch64/AArch64Subtarget.cpp:108
break;
case CortexX2:
PrefFunctionLogAlignment = 4;
----------------
Add here instead, to keep it with more similar cores.
================
Comment at: llvm/lib/Target/ARM/ARM.td:1334
+def : ProcNoItin<"cortex-a710", [ARMv9a, ProcA710,
+ FeatureHWDivThumb,
----------------
Ordering here and elsewhere, and the formatting is a little off.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D113256/new/
https://reviews.llvm.org/D113256
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
