aaron.ballman edited reviewers, added: aaron.ballman, whisperity, hokein; removed: sergio.martins, iamsergio, chgans, nocnokneo, kfunk, alexfh_, segoon. aaron.ballman requested changes to this revision. aaron.ballman added a comment. This revision now requires changes to proceed. Herald added a subscriber: rnkovacs.
Modifying the reviewer list a bit (feel free to re-add yourself if you were dropped but still wanted to provide review). Thank you for working on this! Previously, the only way to get a clang-tidy plugin was to use a clang static analyzer plugin and run it through clang-tidy, which is a lot of hoops to jump through. However, that may raise an interesting question -- how well does this functionality work when there are static analyzer and tidy plugins (I'm presuming it'll run them both)? At a minimum, I think these changes require test coverage. Also, the release notes should be updated to remark on the new functionality, documentation should be added that explains this is supported, and we may also want to consider adding an in-tree example (clang-tidy doesn't have an `examples` folder like Clang does, but this seems like a good reason for us to add one). But I think this is the correct direction to do -- this is functionality I've wished I had several times in the past. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111100/new/ https://reviews.llvm.org/D111100 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
