ChuanqiXu marked 7 inline comments as done.
ChuanqiXu added inline comments.
================
Comment at: clang/lib/Sema/SemaModule.cpp:722-723
+void Sema::PopGlobalModuleFragment() {
+ assert(!ModuleScopes.empty() && getCurrentModule().isGlobalModule() &&
+ "left the wrong module scope, which is not global module fragment");
+ ModuleScopes.pop_back();
----------------
aaron.ballman wrote:
> FWIW, this seems to be failing to compile according to the precommit CI.
> ```
> FAILED: tools/clang/lib/Sema/CMakeFiles/obj.clangSema.dir/SemaModule.cpp.o
> CCACHE_CPP2=yes CCACHE_HASHDIR=yes /usr/bin/ccache /usr/bin/clang++
> -DBUILD_EXAMPLES -DCLANG_ROUND_TRIP_CC1_ARGS=ON -DGTEST_HAS_RTTI=0 -D_DEBUG
> -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS
> -D__STDC_LIMIT_MACROS -Itools/clang/lib/Sema
> -I/var/lib/buildkite-agent/builds/llvm-project/clang/lib/Sema
> -I/var/lib/buildkite-agent/builds/llvm-project/clang/include
> -Itools/clang/include -Iinclude
> -I/var/lib/buildkite-agent/builds/llvm-project/llvm/include -gmlt -fPIC
> -fvisibility-inlines-hidden -Werror=date-time
> -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter
> -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic
> -Wno-long-long -Wc++98-compat-extra-semi -Wimplicit-fallthrough
> -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor
> -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion
> -Wmisleading-indentation -fdiagnostics-color -ffunction-sections
> -fdata-sections -fno-common -Woverloaded-virtual -Wno-nested-anon-types -O3
> -DNDEBUG -fno-exceptions -fno-rtti -UNDEBUG -std=c++14 -MD -MT
> tools/clang/lib/Sema/CMakeFiles/obj.clangSema.dir/SemaModule.cpp.o -MF
> tools/clang/lib/Sema/CMakeFiles/obj.clangSema.dir/SemaModule.cpp.o.d -o
> tools/clang/lib/Sema/CMakeFiles/obj.clangSema.dir/SemaModule.cpp.o -c
> /var/lib/buildkite-agent/builds/llvm-project/clang/lib/Sema/SemaModule.cpp
> /var/lib/buildkite-agent/builds/llvm-project/clang/lib/Sema/SemaModule.cpp:722:53:
> error: member reference type 'clang::Module *' is a pointer; did you mean to
> use '->'?
> assert(!ModuleScopes.empty() && getCurrentModule().isGlobalModule() &&
> ~~~~~~~~~~~~~~~~~~^
> ->
> /usr/include/assert.h:93:27: note: expanded from macro 'assert'
> (static_cast <bool> (expr) \
> ^~~~
> 1 error generated.
> ```
Oh, my bad. I forgot to run tests under debug locally.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D110215/new/
https://reviews.llvm.org/D110215
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
