nickdesaulniers added inline comments.
================ Comment at: clang/lib/AST/APValue.cpp:44-46 + false} {} APValue::LValueBase::LValueBase(const Expr *P, unsigned I, unsigned V) + : Ptr(P), Local{I, V, false} {} ---------------- I think a common convention in LLVM is to have comments like: `Local{I, V, /*NoCFIValue=*/`false}` for boolean parameters. https://llvm.org/docs/CodingStandards.html#comment-formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108479/new/ https://reviews.llvm.org/D108479 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits