nickdesaulniers requested changes to this revision. nickdesaulniers added a comment. This revision now requires changes to proceed.
Thanks for the patch! ================ Comment at: clang/test/CodeGen/arm-tphard.c:10 +} + ---------------- Let's make this a test under llvm/test/CodeGen/, using IR: ``` ; RUN: llc --mtriple=armv7-linux-gnueabihf -o - %s | FileCheck %s ; RUN: llc --mtriple=thumbv7-linux-gnu -o - %s | FileCheck %s define dso_local i8* @tphard() "target-features"="+read-tp-hard" { // CHECK-NOT: __aeabi_read_tp %1 = tail call i8* @llvm.thread.pointer() ret i8* %1 } declare i8* @llvm.thread.pointer() ``` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112600/new/ https://reviews.llvm.org/D112600 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits