erichkeane added inline comments.
================
Comment at: clang/lib/Sema/SemaChecking.cpp:16582
+ Diag(Matrix->getBeginLoc(), diag::err_builtin_invalid_arg_type)
+ << 1 << 1 << Matrix->getType();
return ExprError();
----------------
1 nit: On the 'select' lines, please put a /**/ comment next to the integer to
explain what it is. If they were all closer to eachother, I'd suggest doing an
enum for them, but the comment should be good enough.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D112532/new/
https://reviews.llvm.org/D112532
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
