jsji accepted this revision as: jsji. jsji added a comment. This revision is now accepted and ready to land.
LGTM with some nits. ================ Comment at: clang/lib/Sema/SemaChecking.cpp:3382 + if (&TI.getLongDoubleFormat() != &llvm::APFloat::PPCDoubleDouble()) + return Diag(TheCall->getBeginLoc(), diag::err_ppc_builtin_requires_abi) + << "ibmlongdouble"; ---------------- Can you please add reference to documents that define these builtins in descriptions? ================ Comment at: llvm/test/CodeGen/PowerPC/longdouble-pack.ll:2 +; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py +; RUN: llc -mtriple=powerpc64le-unknown-linux < %s | FileCheck %s + ---------------- Can we also include AIX/big endian run lines? ================ Comment at: llvm/utils/TableGen/IntrinsicEmitter.cpp:253 + IIT_AMX = 51, + IIT_PPCF128 = 52, }; ---------------- Additional `,`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112055/new/ https://reviews.llvm.org/D112055 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
