bondhugula added a comment.

@tra While on this, I also wanted to ask as to why clang cuda codegen is using 
an argument on the global ctor and the dtor it's generating. The argument is 
unused and I couldn't find any code comments to support it in either 
`CGCUDANV.cpp` or `CodeGenModule.cpp`.  I assume there is a reason because 
`CodeGenModule.cpp` is generating an explicit bitcast and has additional 
utilities to convert the function type to one with no arguments. Without the 
argument, one could just use `appendToGlobalCtors/Dtors` from `ModuleUtils`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112284/new/

https://reviews.llvm.org/D112284

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to