sammccall added a comment.

In D112498#3086029 <https://reviews.llvm.org/D112498#3086029>, @aganea wrote:

> This Timer is actually the test coverage for that commit.

Ah, our issue is that it runs in production as well as in the tests. Each time 
the parser sees the crash pragma it dumps a bunch of output to stderr, even if 
the pragma is disabled in PP opts.

> If we don’t want it here, I guess you could move it to the Support unit tests?

Makes sense. Do I understand right that we want to a crash recovery context, a 
timer region within it, and then `abort()` within that?
And we're just verifying we can do that a couple of times without crashing?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112498/new/

https://reviews.llvm.org/D112498

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to