GMNGeoffrey accepted this revision. GMNGeoffrey added inline comments. This revision is now accepted and ready to land.
================ Comment at: utils/bazel/llvm-project-overlay/clang/include/clang/Config/config.h:78 /* Define if we have sys/resource.h (rlimits) */ -#define CLANG_HAVE_RLIMITS 1 +/* CLANG_HAVE_RLIMITS defined in Bazel */ ---------------- Hmm I think we probably should have a change-detector for this config as well as the LLVM ones ================ Comment at: utils/bazel/llvm-project-overlay/llvm/cc_plugin_library.bzl:33 + for impl_name in [dll_name, dylib_name, so_name]: + cc_binary( + name = impl_name, ---------------- What about this makes `binary_alias` no longer work? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112399/new/ https://reviews.llvm.org/D112399 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
