aaron.ballman added reviewers: rjmccall, erichkeane, Anastasia. aaron.ballman added a comment.
Adding a few more reviewers with more familiarity with codegen and address spaces to make sure we've not missed something here outside of SYCL. ================ Comment at: clang/lib/CodeGen/CodeGenTypes.cpp:636-638 + unsigned AS = PointeeType->isFunctionTy() + ? getDataLayout().getProgramAddressSpace() + : Context.getTargetAddressSpace(ETy); ---------------- The review summary says that this is a fix for SYCL, but the fix itself happens for all targets, not just SYCL. If that's intentional, are we sure it's correct? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111566/new/ https://reviews.llvm.org/D111566 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
