kbobyrev marked an inline comment as done. kbobyrev added inline comments.
================ Comment at: llvm/include/llvm/Support/FileSystem/UniqueID.h:68 + return hash_value( + std::pair<unsigned, unsigned>(Tag.getDevice(), Tag.getFile())); + } ---------------- ntfshard wrote: > In this line a narrow conversion, and MSVC compiler can't build it with > warnings as error key. > getDevice and getFile returns uint64_t but pair expects unsigned ints. > > Thank you for noticing! Fixed in https://github.com/llvm/llvm-project/commit/88303693ce97cf842f0714068c2cae44cd6515e1 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110925/new/ https://reviews.llvm.org/D110925 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
