Hi Alex, I’ll take a look. Not sure how long it takes though. Please revert it. I don’t have the permission to commit yet.
Could you share more information about the crash? What is the command line to repro the crash and which environment it crashed. Thanks Xiang Sent from Mail<https://go.microsoft.com/fwlink/?LinkId=550986> for Windows From: Alexander Kornienko via Phabricator<mailto:revi...@reviews.llvm.org> Sent: Wednesday, October 20, 2021 2:19 PM To: python3k...@outlook.com<mailto:python3k...@outlook.com>; mizve...@gmail.com<mailto:mizve...@gmail.com>; blitzrak...@gmail.com<mailto:blitzrak...@gmail.com>; notst...@gmail.com<mailto:notst...@gmail.com>; shen...@google.com<mailto:shen...@google.com>; rich...@metafoo.co.uk<mailto:rich...@metafoo.co.uk>; bhuvanendra.kum...@amd.com<mailto:bhuvanendra.kum...@amd.com>; mlek...@skidmore.edu<mailto:mlek...@skidmore.edu>; jlero...@apple.com<mailto:jlero...@apple.com>; chris.biene...@me.com<mailto:chris.biene...@me.com>; aaron.ball...@gmail.com<mailto:aaron.ball...@gmail.com> Cc: ale...@google.com<mailto:ale...@google.com>; ndesaulni...@google.com<mailto:ndesaulni...@google.com>; cfe-commits@lists.llvm.org<mailto:cfe-commits@lists.llvm.org>; david.gr...@arm.com<mailto:david.gr...@arm.com>; ruiling.s...@amd.com<mailto:ruiling.s...@amd.com> Subject: [PATCH] D111109: AddGlobalAnnotations for function with or without function body. alexfh added a comment. Reduced test case: template <class a> void b(a); template <typename c> class d { public: class e { public: c *f(); }; e *g(); }; template <class> class j; template <class h, class... i> class j<h(i...)> { public: class k { public: k(int *); ~k(); }; int n(); d<int *> l; }; template <class h, class... i> int j<h(i...)>::n() { auto m = l.g()->f(); k a(*m); b(a); } template <class h, class... i> j<h(i...)>::k::~k() __attribute__((annotate(""))) {} class o { int m_fn4(); j<int()> p; }; int o::m_fn4() { p.n(); } Please revert the commit if there is no quick and obvious solution. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111109/new/ https://reviews.llvm.org/D111109
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
