steakhal accepted this revision. steakhal added a comment. I love it.
================ Comment at: clang/unittests/AST/ASTImporterTest.cpp:6189 + // Check if the import was correct. + CXXConstructorDecl *ToCtor = *ToL->ctor_begin(); + const auto *ToFPT = ToCtor->getType()->getAs<FunctionProtoType>(); ---------------- balazske wrote: > steakhal wrote: > > Please assert that the number of constructors is correct. > > I would rather recommend doing so in the //from// case as well. > Here the goal is only to get a copy constructor, not to test if all > constructors are imported. To get the constructor count relatively much > additional code is needed (there is no function for it). I see. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112013/new/ https://reviews.llvm.org/D112013 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
