lhames added a comment.

In D111863#3074404 <https://reviews.llvm.org/D111863#3074404>, @housel wrote:

> To be clear, this new code parses exactly as much of each FDE as the existing 
> `__register_frame`/`__unw_add_dynamic_fde` does, including doing the same 
> work to compute the record length. Neither needs to parse the instructions at 
> registration time.

Right -- I should have actually looked at the implementation of 
`__unw_add_dynamic_fde`. ;)

@joerg -- We have always registered every FDE in the JIT. This is an 
improvement over what we have, not a regression. Is there some more efficient 
approach that you would recommend? Otherwise I think this should go in.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111863/new/

https://reviews.llvm.org/D111863

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to