fcambus added inline comments.
================ Comment at: clang/lib/Basic/Targets/OSTargets.h:182 DefineStd(Builder, "unix", Opts); + if (this->HasFloat128) + Builder.defineMacro("__FLOAT128__"); ---------------- mgorny wrote: > Maybe I'm missing something but do you actually need to state `this->` > explicitly? Seems like it is necessary, yes. Other targets (Haiku, Linux, OpenBSD, Solaris) use the same `if (this->HasFloat128)` check, and build fails if I remove the `this->` part. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111760/new/ https://reviews.llvm.org/D111760 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits