sdesmalen added inline comments.
================ Comment at: clang/docs/ReleaseNotes.rst:185-188 +architectural features. For example, we can compile code with +"-mcpu=generic -mtune=cortex-a57" where the architectural features are +defined according to a "generic" CPU, but we use the scheduling options +for a "cortex-a57" CPU. ---------------- nit: compiling with "-mcpu=generic -mtune=cortex-a57" will not enable any Cortex-a57 specific architecture features, but will enable certain optimizations specific to Cortex-a57 CPUs and enable the use of a more accurate scheduling model. ================ Comment at: clang/test/Driver/aarch64-mtune.c:5 +// RUN: %clang -target aarch64-unknown-unknown -c -### %s 2>&1 \ +// RUN: | FileCheck %s -check-prefix=notune +// notune-NOT: "-tune-cpu" "generic" ---------------- nit: Did you make these prefixes lower-case on purpose? ================ Comment at: llvm/docs/ReleaseNotes.rst:80 +and optimisations to be enabled independently of the architecture. If the +"tune-cpu" attribute is absent we tune according to the "target-cpu". ---------------- nit: s/we tune/it tunes/ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110258/new/ https://reviews.llvm.org/D110258 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
