dblaikie added inline comments.
================
Comment at: clang/lib/CodeGen/CodeGenAction.cpp:355-356
+ if (CodeGenOpts.ClearASTBeforeBackend) {
+ // The ASTContext may be unusable after this.
+ C.cleanup();
C.getAllocator().Reset();
----------------
Any chance of refactoring such that the ASTContext is scoped such that it is
destroyed here, rather than rendered unusable - to reduce the chance that it'd
be accidentally used after this point?
Like what happens if CompilerInstance::setASTContext(nullptr) is called? It
wouldn't null out everyone's ASTContext pointers, but would mean there's no
object there - perhaps crash harder/faster than a "cleaned up" ASTContext being
used?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D111767/new/
https://reviews.llvm.org/D111767
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
