phosek added a comment.

I'm still worried that this solution as implemented is going to break existing 
users, including major one like Rust.

I'm not also not a fan of special casing individual targets like Fuchsia 
directly inside `Driver`, I believe that any per-target logic should live in 
the corresponding `ToolChain` subclass.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110663/new/

https://reviews.llvm.org/D110663

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to