carlosgalvezp added a comment. Regarding test coverage, I'm unsure if what you propose is intended. I have looked at similar aliases and I can't find any test at all for them either. For example `modernize-avoid-c-arrays` is aliased by "cppcoreguidelines" and "hicpp" and I cannot find tests for them. So perhaps there's a reason for this?
I had a look at your example with `check_prefix` but I'm not sure it fits well here. In the case you mention, it's about running *the same check* with different flags. Here we are talking about running *different checks* (though aliased) in the same .cpp test file. If we want to treat aliases as "first class checks", I think it only makes sense to have a "first class test" also for the aliases. But that leads to code duplication, of course. Feels like this should be discussed in cfe-dev, but perhaps it's outside the scope of this patch? Right now there's really nothing new to test - the check is now a perfect alias, and the test strategy is consistent with other aliases. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111041/new/ https://reviews.llvm.org/D111041 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
