salman-javed-nz added inline comments.
================
Comment at: clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.cpp:446
SuppressionErrors.emplace_back(Error.getValue());
- return false;
}
----------------
carlosgalvezp wrote:
> I had to remove these "return false", otherwise I would not get errors
> regarding "Found NOLINTBEGIN that was unmatched by a NOLINTEND". Not really
> sure why they were there in the first place.
>
> All unit tests pass with this patch.
The reason for the `return false` was because the file is already determined to
have a unmatched `NOLINTBEGIN`, so it's FUBAR and probably not worth checking
the remainder of anyway. I don't mind either way.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D111208/new/
https://reviews.llvm.org/D111208
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
