dexonsmith added a comment.
Seems like a reasonable move to me.
================
Comment at: llvm/include/llvm/MC/TargetRegistry.h:18-19
#ifndef LLVM_SUPPORT_TARGETREGISTRY_H
#define LLVM_SUPPORT_TARGETREGISTRY_H
----------------
Should be `LLVM_MC_TARGETREGISTRY_H` now.
================
Comment at: llvm/include/llvm/MC/TargetRegistry.h:1376
#endif // LLVM_SUPPORT_TARGETREGISTRY_H
----------------
Same here.
================
Comment at: llvm/lib/MC/TargetRegistry.cpp:52-53
if (!TheTarget) {
- Error = ": error: unable to get target for '"
- + TheTriple.getTriple()
- + "', see --version and --triple.\n";
+ Error = ": error: unable to get target for '" + TheTriple.getTriple() +
+ "', see --version and --triple.\n";
return nullptr;
----------------
I'm guessing this formatting crept in because of the file move (also in the
header). Might be nice to reduce the diff by clang-formatting the two files
ahead of time.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D111454/new/
https://reviews.llvm.org/D111454
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
