phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land.
LGTM ================ Comment at: clang/include/clang/Basic/LangOptions.def:432 +VALUE_LANGOPT(FuchsiaAPILevel, 32, 0, "Fuchsia API Level") + ---------------- ================ Comment at: clang/include/clang/Driver/Options.td:3166 +def ffuchsia_api_level_EQ : Joined<["-"], "ffuchsia-api-level=">, + Group<m_Group>, Flags<[CC1Option]>, HelpText<"Set Fuchsia API Level target">, + MarshallingInfoInt<LangOpts<"FuchsiaAPILevel">>; ---------------- ================ Comment at: clang/test/Driver/attr-availability-fuchsia.c:2-25 +// RUN: %clang -target x86_64-unknown-fuchsia -ffuchsia-api-level=16 -c %s -### 2>&1| FileCheck %s +// +// RUN: not %clang -target x86_64-unknown-fuchsia -ffuchsia-api-level=16.0.0 -c %s 2>&1| FileCheck %s --check-prefix=CHECK-ERROR + +// It should also be exposed to non-fuchsia platforms. This is desireable when +// using common Fuchsia headers for building host libraries that also depend on +// the Fuchsia version (such as using a compatible host-side FIDL library that ---------------- Can you reorder this so `CHECK` always follows the corresponding `RUN` and separate each case by an empty line? I find it more readable. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108592/new/ https://reviews.llvm.org/D108592 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
