tejohnson added inline comments.
================
Comment at: llvm/include/llvm/Support/Caching.h:68
+/// already exist.
+Expected<NativeObjectCache> localCache(StringRef CacheDirectoryPath,
+ AddBufferFn AddBuffer,
----------------
Nit: document new parameter.
================
Comment at: llvm/lib/Support/Caching.cpp:36
+ SmallString<10> CacheName = CacheNameRef;
return [=](unsigned Task, StringRef Key) -> AddStreamFn {
----------------
Is this copy necessary? I believe sys::path::append takes a Twine and
eventually makes a copy of it.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D111371/new/
https://reviews.llvm.org/D111371
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
