carlosgalvezp added inline comments.
================
Comment at: clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.cpp:353
+ if (SuppressionIsSpecific)
+ *SuppressionIsSpecific = true;
}
----------------
salman-javed-nz wrote:
> So when this function is called with args `Line = "NOLINTBEGIN(google*)"` and
> `CheckName = "google-explicit-constructor"`, it will return true with
> `*SuppressionIsSpecific = true`.
> Should `*SuppressionIsSpecific = false` instead here?
Good point. I honestly don't understand what SuppressionIsSpecific means and
how it's used downstream, could you clarify?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D111208/new/
https://reviews.llvm.org/D111208
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
