craig.topper added inline comments.
================ Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoV.td:1372 + (VMANDN_MM VR:$vd, VR:$vs2, VR:$vs1), 0>; + +def : InstAlias<"vmornot.mm $vd, $vs2, $vs1", ---------------- Probably not worth having a blank line between vmandnot and vmornot ================ Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoVPseudos.td:4018 //===----------------------------------------------------------------------===// -// 16.2. Vector mask population count vpopc +// 16.2. Vector mask population count vcpop //===----------------------------------------------------------------------===// ---------------- To be consistent with line 4683 ``` // 16.2. Vector count population in mask vcpop.m ``` ================ Comment at: llvm/test/MC/RISCV/rvv/aliases.s:82 +# ALIAS: vcpop.m a2, v4, v0.t # encoding: [0x57,0x26,0x48,0x40] +# NO-ALIAS: vcpop.m a2, v4, v0.t # encoding: [0x57,0x26,0x48,0x40] +vpopc.m a2, v4, v0.t ---------------- line "a2, v4, v0.t" up with the previous line. ================ Comment at: llvm/test/MC/RISCV/rvv/aliases.s:85 +# ALIAS: vmandn.mm v8, v4, v20 # encoding: [0x57,0x24,0x4a,0x62] +# NO-ALIAS: vmandn.mm v8, v4, v20 # encoding: [0x57,0x24,0x4a,0x62] +vmandnot.mm v8, v4, v20 ---------------- Same here ================ Comment at: llvm/test/MC/RISCV/rvv/aliases.s:88 +# ALIAS: vmorn.mm v8, v4, v20 # encoding: [0x57,0x24,0x4a,0x72] +# NO-ALIAS: vmorn.mm v8, v4, v20 # encoding: [0x57,0x24,0x4a,0x72] +vmornot.mm v8, v4, v20 ---------------- And here Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111062/new/ https://reviews.llvm.org/D111062 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
