xbolva00 accepted this revision. xbolva00 added a comment. This revision is now accepted and ready to land.
One small comment about side effects, otherwise LG. Please wait a +-day for potentional review comments. ================ Comment at: clang/docs/ReleaseNotes.rst:54 -- ... +- -Wbitwise-instead-of-logical (part of -Wbool-operation) warns about use of bitwise with boolean operands ---------------- I think we should mention that with boolean operands which have side effects. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111215/new/ https://reviews.llvm.org/D111215 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits