whisperity added a comment. In D110614#3038519 <https://reviews.llvm.org/D110614#3038519>, @carlosgalvezp wrote:
> Hi! Are there any more issues I should address? It would be nice to get it > merged since it fixes quite a few FPs. I'm not seeing anything immediate to add. I like the proper printing with the template parameters. 🙂 Just in case: add another set of tests where the template instantiation (both diagnosed and not diagnosed) is behind a `typedef`, just to see how well the diagnostic is printed and generated. Otherwise, I'm happy with this. > `// Fixes https://bugs.llvm.org/show_bug.cgi?id=51912` I still think that maybe this whole fiasco is worth either a bug report against `Sema` on its own, or just a question-phrased mail to `cfe-dev`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110614/new/ https://reviews.llvm.org/D110614 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
