Anastasia added a comment. In http://reviews.llvm.org/D19780#442305, @rivanvx wrote:
> @Anastasia I looked into introducing a separate getOpenCLVersion() function > (or perhaps three - major version, minor version and version string). This > would have to be used in lib/CodeGen/TargetInfo.cpp and > lib/Parse/ParseDecl.cpp, and I am undecided on where should one put this > code. One option would be in Parse/Parser.h inside class Parser, and then > TargetInfo.cpp would have to include Parser.h, unless we decide to declare it > inside AST/ASTContext.h. > > In any case, this has so far two usages, and they are different (major and > minor version in TargetInfo.cpp vs version string in ParseDecl.cpp). > Therefore, I would propose to leave this as is for now, and rethink it after > the same code has to be used in more places. Sure! It seems to make sense to me to have more use cases first. ;) Thanks for looking at it! http://reviews.llvm.org/D19780 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
