martong added inline comments.
================
Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:2108
+LLVM_NODISCARD ProgramStateRef
+EquivalenceClass::removeMember(ProgramStateRef State, const SymbolRef Old) {
+
----------------
Remove `const `
================
Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:2123
+ ClsMembers = F.remove(ClsMembers, Old);
+ assert(!ClsMembers.isEmpty() &&
+ "Class should have had at least two members before member removal");
----------------
Comment that this is a precondition.
================
Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:2156
+ assert(find(State, MemberSym) == find(State, SimplifiedMemberSym));
+ // Remove the old and more complex symbol.
+ State = find(State, MemberSym).removeMember(State, MemberSym);
----------------
TODO add Performance and complexity essay here.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D106823/new/
https://reviews.llvm.org/D106823
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
