kadircet added inline comments.
================
Comment at: clang-tools-extra/clangd/Selection.cpp:745
+      if (auto *FD = llvm::dyn_cast<FieldDecl>(ME->getMemberDecl())) {
+        if (FD->getParent()->isAnonymousStructOrUnion())
+          return SourceRange(ME->getMemberLoc(), ME->getEndLoc());
----------------
in theory this check should be redundant, as each field should own its tokens. 
but given the complexity of C++ just wanted to be conservative.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110825/new/

https://reviews.llvm.org/D110825

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to