Author: d0k Date: Fri May 27 07:52:19 2016 New Revision: 270991 URL: http://llvm.org/viewvc/llvm-project?rev=270991&view=rev Log: [Frontend] StringRefize and fix bad indentation.
NFC intended. Modified: cfe/trunk/lib/Frontend/HeaderIncludeGen.cpp Modified: cfe/trunk/lib/Frontend/HeaderIncludeGen.cpp URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Frontend/HeaderIncludeGen.cpp?rev=270991&r1=270990&r2=270991&view=diff ============================================================================== --- cfe/trunk/lib/Frontend/HeaderIncludeGen.cpp (original) +++ cfe/trunk/lib/Frontend/HeaderIncludeGen.cpp Fri May 27 07:52:19 2016 @@ -49,31 +49,31 @@ public: }; } -static void PrintHeaderInfo(raw_ostream *OutputFile, const char* Filename, +static void PrintHeaderInfo(raw_ostream *OutputFile, StringRef Filename, bool ShowDepth, unsigned CurrentIncludeDepth, bool MSStyle) { - // Write to a temporary string to avoid unnecessary flushing on errs(). - SmallString<512> Pathname(Filename); - if (!MSStyle) - Lexer::Stringify(Pathname); - - SmallString<256> Msg; - if (MSStyle) - Msg += "Note: including file:"; - - if (ShowDepth) { - // The main source file is at depth 1, so skip one dot. - for (unsigned i = 1; i != CurrentIncludeDepth; ++i) - Msg += MSStyle ? ' ' : '.'; + // Write to a temporary string to avoid unnecessary flushing on errs(). + SmallString<512> Pathname(Filename); + if (!MSStyle) + Lexer::Stringify(Pathname); + + SmallString<256> Msg; + if (MSStyle) + Msg += "Note: including file:"; + + if (ShowDepth) { + // The main source file is at depth 1, so skip one dot. + for (unsigned i = 1; i != CurrentIncludeDepth; ++i) + Msg += MSStyle ? ' ' : '.'; - if (!MSStyle) - Msg += ' '; - } - Msg += Pathname; - Msg += '\n'; + if (!MSStyle) + Msg += ' '; + } + Msg += Pathname; + Msg += '\n'; - OutputFile->write(Msg.data(), Msg.size()); - OutputFile->flush(); + *OutputFile << Msg; + OutputFile->flush(); } void clang::AttachHeaderIncludeGen(Preprocessor &PP, @@ -104,8 +104,8 @@ void clang::AttachHeaderIncludeGen(Prepr // generation of Make / Ninja file dependencies for implicit includes, such // as sanitizer blacklists. It's only important for cl.exe compatibility, // the GNU way to generate rules is -M / -MM / -MD / -MMD. - for (auto Header : DepOpts.ExtraDeps) - PrintHeaderInfo(OutputFile, Header.c_str(), ShowDepth, 2, MSStyle); + for (const auto &Header : DepOpts.ExtraDeps) + PrintHeaderInfo(OutputFile, Header, ShowDepth, 2, MSStyle); PP.addPPCallbacks(llvm::make_unique<HeaderIncludesCallback>( &PP, ShowAllHeaders, OutputFile, DepOpts, OwnsOutputFile, ShowDepth, MSStyle)); @@ -132,7 +132,7 @@ void HeaderIncludesCallback::FileChanged // place where we drop back to a nesting depth of 1. if (CurrentIncludeDepth == 1 && !HasProcessedPredefines) { if (!DepOpts.ShowIncludesPretendHeader.empty()) { - PrintHeaderInfo(OutputFile, DepOpts.ShowIncludesPretendHeader.c_str(), + PrintHeaderInfo(OutputFile, DepOpts.ShowIncludesPretendHeader, ShowDepth, 2, MSStyle); } HasProcessedPredefines = true; _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits