steakhal added a comment.
nits
================
Comment at: clang/test/Analysis/ptr-arith.c:336
+ int v;
+ char y;
+};
----------------
It's probably unnecessary.
================
Comment at: clang/test/Analysis/ptr-arith.c:339
+
+void clang_analyzer_dump(int);
+
----------------
I would probably put this at the top of the file.
================
Comment at: clang/test/Analysis/ptr-arith.c:344
+ struct s ss = *ps;
+ clang_analyzer_dump((*ps).v); // expected-warning{{reg_$3<int
SymRegion{reg_$0<struct s * ps>}.v>}}
+ clang_analyzer_dump(ps[0].v); // expected-warning{{reg_$3<int
SymRegion{reg_$0<struct s * ps>}.v>}}
----------------
You should not hardcode the internal counter in the tests.
You can use regexp matching to workaround the issue. Here is an example:
`// expected-warning-re@-2 {{reg_${{[[:digit:]]+}}<int v>}}`
`@-2` denotes that we expect a warning two lines above.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D110625/new/
https://reviews.llvm.org/D110625
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
