aeubanks created this revision.
aeubanks requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
A followup to D110201 <https://reviews.llvm.org/D110201>.
For example, we'd set OptimizationRemarkMissed's Regex to '.*' when
encountering -Rpass. This doesn't actually affect remarks we emit
because in clang::ProcessWarningOptions() we'll separately look at all
-R arguments and turn on/off corresponding diagnostic groups.
Downstream users have somehow noticed this.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D110673
Files:
clang/lib/Frontend/CompilerInvocation.cpp
Index: clang/lib/Frontend/CompilerInvocation.cpp
===================================================================
--- clang/lib/Frontend/CompilerInvocation.cpp
+++ clang/lib/Frontend/CompilerInvocation.cpp
@@ -1201,6 +1201,8 @@
Result.Kind = CodeGenOptions::RK_Disabled;
else if (Value == "no-everything")
Result.Kind = CodeGenOptions::RK_DisabledEverything;
+ else
+ continue;
if (Result.Kind == CodeGenOptions::RK_Disabled ||
Result.Kind == CodeGenOptions::RK_DisabledEverything) {
Index: clang/lib/Frontend/CompilerInvocation.cpp
===================================================================
--- clang/lib/Frontend/CompilerInvocation.cpp
+++ clang/lib/Frontend/CompilerInvocation.cpp
@@ -1201,6 +1201,8 @@
Result.Kind = CodeGenOptions::RK_Disabled;
else if (Value == "no-everything")
Result.Kind = CodeGenOptions::RK_DisabledEverything;
+ else
+ continue;
if (Result.Kind == CodeGenOptions::RK_Disabled ||
Result.Kind == CodeGenOptions::RK_DisabledEverything) {
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
