jdoerfert accepted this revision.
jdoerfert added a comment.
This revision is now accepted and ready to land.

LG.

We might be able to revert/simplify this eventually again but for now it makes 
it much simpler to distinguish the distribute and workshare (=for) via their 
call site.



================
Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:2879
+    StaticInitFunction =
+        createForStaticInitFunction(Values.IVSize, Values.IVSigned);
+
----------------
Could we pass the 4 potential functions to `createForStaticInitFunction` (or 
similar name) to avoid the duplication? Or just pass a flag.



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110429/new/

https://reviews.llvm.org/D110429

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to