david-arm added a comment. In D110258#3023818 <https://reviews.llvm.org/D110258#3023818>, @dmgreen wrote:
> Sounds great. Glad to see us taking this route. > > Unfortunately I think we do need to split the subtargetfeatures up into arch > flags and tune flags. Same for the details in > AArch64Subtarget::initializeProperties. It is hopefully a fairly mechanical > process, but they are an important part of tuning and without them -mtune is > only a half-working option. > > Are you happy to give that a go too? Hi @dmgreen, sure I can try. The only problem is that I don't really understand what to do here. I used the X86Subtarget as a guidance and the TuneCPU flag only seems to be used for scheduling and nothing else. It's not obvious to me how the TuneCPU flag decides the features as I thought it was purely for scheduling? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110258/new/ https://reviews.llvm.org/D110258 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
