bakinovsky-m created this revision. bakinovsky-m added a reviewer: aaron.ballman. bakinovsky-m created this object with edit policy "Administrators". bakinovsky-m added a project: clang-tools-extra. bakinovsky-m requested review of this revision. Herald added a subscriber: cfe-commits.
bugprone-virtual-near-miss & performance-type-promotion-in-math-fn Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D110525 Files: clang-tools-extra/docs/clang-tidy/checks/bugprone-virtual-near-miss.rst clang-tools-extra/docs/clang-tidy/checks/performance-type-promotion-in-math-fn.rst Index: clang-tools-extra/docs/clang-tidy/checks/performance-type-promotion-in-math-fn.rst =================================================================== --- clang-tools-extra/docs/clang-tidy/checks/performance-type-promotion-in-math-fn.rst +++ clang-tools-extra/docs/clang-tidy/checks/performance-type-promotion-in-math-fn.rst @@ -6,7 +6,7 @@ Finds calls to C math library functions (from ``math.h`` or, in C++, ``cmath``) with implicit ``float`` to ``double`` promotions. -For example, warns on ``::sin(0.f)``, because this funciton's parameter is a +For example, warns on ``::sin(0.f)``, because this function's parameter is a double. You probably meant to call ``std::sin(0.f)`` (in C++), or ``sinf(0.f)`` (in C). Index: clang-tools-extra/docs/clang-tidy/checks/bugprone-virtual-near-miss.rst =================================================================== --- clang-tools-extra/docs/clang-tidy/checks/bugprone-virtual-near-miss.rst +++ clang-tools-extra/docs/clang-tidy/checks/bugprone-virtual-near-miss.rst @@ -15,6 +15,6 @@ }; struct Derived : Base { - virtual funk(); + virtual void funk(); // warning: 'Derived::funk' has a similar name and the same signature as virtual method 'Base::func'; did you mean to override it? };
Index: clang-tools-extra/docs/clang-tidy/checks/performance-type-promotion-in-math-fn.rst =================================================================== --- clang-tools-extra/docs/clang-tidy/checks/performance-type-promotion-in-math-fn.rst +++ clang-tools-extra/docs/clang-tidy/checks/performance-type-promotion-in-math-fn.rst @@ -6,7 +6,7 @@ Finds calls to C math library functions (from ``math.h`` or, in C++, ``cmath``) with implicit ``float`` to ``double`` promotions. -For example, warns on ``::sin(0.f)``, because this funciton's parameter is a +For example, warns on ``::sin(0.f)``, because this function's parameter is a double. You probably meant to call ``std::sin(0.f)`` (in C++), or ``sinf(0.f)`` (in C). Index: clang-tools-extra/docs/clang-tidy/checks/bugprone-virtual-near-miss.rst =================================================================== --- clang-tools-extra/docs/clang-tidy/checks/bugprone-virtual-near-miss.rst +++ clang-tools-extra/docs/clang-tidy/checks/bugprone-virtual-near-miss.rst @@ -15,6 +15,6 @@ }; struct Derived : Base { - virtual funk(); + virtual void funk(); // warning: 'Derived::funk' has a similar name and the same signature as virtual method 'Base::func'; did you mean to override it? };
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits