kamaub added inline comments.
================
Comment at: clang/lib/Sema/SemaChecking.cpp:3518
+// valid. The argument must be either a 'float' or a 'double'.
+bool Sema::CheckPPCTestDataClassType(CallExpr *TheCall) {
+ QualType ArgType = TheCall->getArg(0)->getType();
----------------
lei wrote:
> I don't think this need to be function in the Sema class. It can just be a
> static function.
This is a great suggestion, I'm wondering if the function is even needed at all
though since the code block is quite small and only called once, having it
inside the case statement seems more readable to me.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D109437/new/
https://reviews.llvm.org/D109437
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
