tianshilei1992 marked 2 inline comments as done. tianshilei1992 added inline comments.
================ Comment at: llvm/include/llvm/Frontend/OpenMP/OMPConstants.h:134 + SPMD = 0x2, +}; + ---------------- jdoerfert wrote: > If you copy the LLVM_MARK_AS_BITMASK_ENUM stuff you can actually use the enum > class as bitmask w/o the static casts all the time. > I'd also suggest to create the combinations here, so GenericSPMD = Generic | > SPMD;. That's very nice to know. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110029/new/ https://reviews.llvm.org/D110029 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits