nridge added a comment. In D110051#3009378 <https://reviews.llvm.org/D110051#3009378>, @kadircet wrote:
> I am not aware of how the intersecting hints are handled in the > implementation on the client side nor in the proposal today. After this patch > we might still produce them if for whatever reason there are different kinds > of hints for the same range. Is this OK? The behaviour with the duplicated hints in vscode was that they appeared one after the other, e.g. `: int : int : int`. So, wrong but not catastrophic. I don't think we're likely to get a parameter hint and a type hint at the same location, but if you're concerned, I could revise the patch to ignore the hint kind during the comparison. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110051/new/ https://reviews.llvm.org/D110051 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
