nickdesaulniers added inline comments.

================
Comment at: clang/test/CodeGen/memcpy-inline-builtin.c:1
+// RUN: %clang_cc1 -triple x86_64-unknown-unknown -S -emit-llvm -o - %s 
-disable-llvm-passes | FileCheck %s
+//
----------------
nickdesaulniers wrote:
> Would `-emit-codegen-only` be more appropriate here than 
> `-disable-llvm-passes`?
No; but I don't think we need `-disable-llvm-passes` since we haven't 
explicitly enabled additional optimization modes via `-O` flags? ie. I suspect 
if we drop `-disable-llvm-passes` then nothing changes?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109967/new/

https://reviews.llvm.org/D109967

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to