MyDeveloperDay added a comment. In D92257#3003281 <https://reviews.llvm.org/D92257#3003281>, @byronhe wrote:
> Hi guys，i found `SpacesInLineCommentPrefix` does not support other encoding > such as utf8 ， > I am curious why there is a `isAlphanumeric` limit in > `BreakableLineCommentSection::BreakableLineCommentSection()` ? > I want to make some contribution to make it support utf8, what should i do ? see https://llvm.org/docs/Contributing.html but in essence: 1. open a bug at https://bugs.llvm.org/ 2. clone the llvm repo from gitub 3. build the repo 4. add unit tests in clang/unittests/Format that show the problem 5. add the code that fixes the issue 6. upload a diff of the patch to reviews.llvm.org 7. add clang-format project tag and at least me as a reviewer and I can help fill in the rest This sounds like a great new contributor idea.. go for it! I'll support this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92257/new/ https://reviews.llvm.org/D92257 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
