vaibhav.y added a comment.
> Btw, is the intent for this functionality to replace what's in > SarifDiagnostics.cpp > (https://github.com/llvm/llvm-project/blob/main/clang/lib/StaticAnalyzer/Core/SarifDiagnostics.cpp) > fairly immediately? Or are we going to carry both implementations? This is intended to replace what's in `SarifDiagnostics.cpp` in the future, it copies quite a few functions over from there as well. There is more work planned on this, since we've decided that the best way to add this feature without too much disrpution would be as follows: 1. Add an interface to create sarif docs 2. Add an adapter that can translate a specific diagnostic type (e.g. `PathDiagnostic`) to sarif 3. Rewrite the existing code to use the adapter 4. Introduce the same to clang internals I think ordering the changes like so will let keep the individual changesets narrow, while adding temporary bloat. For now we must keep both implementations. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109701/new/ https://reviews.llvm.org/D109701 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
